Python: ADR for simplified get response #3098
Open
+258
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eavanvalkenburg
requested review from
dmytrostruk,
markwallace-microsoft and
moonbox3
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR proposes an ADR (Architecture Decision Record) for simplifying Python's chat client API by consolidating the get_response and get_streaming_response methods into a single method with a stream parameter. This would leverage Python's type system and overload patterns to provide better type safety while reducing code duplication.
Key Changes
- Proposes consolidating two separate methods (
get_responseandget_streaming_response) into a single method with astreamparameter - Analyzes the implications across all usage areas including agents, decorators, middleware, and provider implementations
- Provides a detailed migration path with backward compatibility considerations
eavanvalkenburg
force-pushed
the
python_single_get_response
branch
from
f51a20d to
b16f403
Compare
dmytrostruk
reviewed
Jan 7, 2026
eavanvalkenburg
force-pushed
the
python_single_get_response
branch
from
c7465ec to
f59fb8c
Compare
moonbox3
reviewed
Jan 9, 2026
TaoChenOSU
reviewed
Jan 9, 2026
TaoChenOSU
reviewed
Jan 9, 2026
eavanvalkenburg
force-pushed
the
python_single_get_response
branch
from
0ec0eff to
ac1692e
Compare
moonbox3
reviewed
Jan 12, 2026
eavanvalkenburg
force-pushed
the
python_single_get_response
branch
from
7d0489c to
b5b4b2f
Compare
eavanvalkenburg
force-pushed
the
python_single_get_response
branch
from
b5b4b2f to
558b1da
Compare
dmytrostruk
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ADR describing the implications of a potential simplification of the
get_responsemethod in ChatClients, this would leverage python's type system and astream=True/Falseparam to steer the users instead of using two separate methods, that already have a lot of overlap.Related to #3096 - Point 5
Description
Contribution Checklist